• src/comio/comio_nix.c

    From Deuc¿@VERT to Git commit to main/sbbs/master on Wednesday, May 17, 2023 10:46:00
    https://gitlab.synchro.net/main/sbbs/-/commit/1c2cce85f0034c91c9c16321
    Modified Files:
    src/comio/comio_nix.c
    Log Message:
    Another Coverity issue fixed.

    Although, Coverity is wrong, close() *can* "accept a negative number",
    it just always returns EBADF... which would behave correctly.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Friday, November 08, 2024 20:40:04
    https://gitlab.synchro.net/main/sbbs/-/commit/b8260ae628da934c414a8377
    Modified Files:
    src/comio/comio_nix.c
    Log Message:
    Don't reset the port baud rate to 0 in comOpen()

    As noticed while trouble-shooting issue #813, calling comOpen() would
    (on Linux, at least) set the port baud rate to 0 bps (B0) which in
    most or all Linux serial drivers triggers special logic to deassert DTR and
    RTS signals (to the modem, to attempt to "hangup" any connection).

    If the app (e.g. sexpots) did not explictily set the port baud rate after calling comOpen(), the port would be unusable. This is not how comOpen() works on Windows.

    So rather than just overwrite all the bits in termios.c_cflag, we clear the fields we know we want to, set the bits we want, and leave the rest (which usually includes the current baud rate, if CBAUD is defined) as-is.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, November 08, 2024 21:19:29
    https://gitlab.synchro.net/main/sbbs/-/commit/7538ce8be4502921c23f3a19
    Modified Files:
    src/comio/comio_nix.c
    Log Message:
    If CBAUD is defined, retain the CBAUD bits in c_cflags

    Otherwise, zero it out. Most termios implementations don't put the
    speed in here, but this *is* where dragons be.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, November 08, 2024 21:20:35
    https://gitlab.synchro.net/main/sbbs/-/commit/bf8bb8248aaac44154147edf
    Modified Files:
    src/comio/comio_nix.c
    Log Message:
    Fix stupid

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net