1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/syncterm/ripper.c

    From Rob Swindell (on Debian L@VERT to Git commit to main/sbbs/master on Wednesday, March 29, 2023 16:29:00
    https://gitlab.synchro.net/main/sbbs/-/commit/41cd8c3af2366120df56154c
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix GCC 12.2 warning

    warning: argument 1 value `18446744073709551608' exceeds maximum
    object size 9223372036854775807 [-Walloc-size-larger-than=]

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Wednesday, April 26, 2023 12:14:00
    https://gitlab.synchro.net/main/sbbs/-/commit/ac4a967c92244c8c12ac6398
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix Win32 console (and likely curses) crash on connect

    RIP initialization was trying to obtain a lock that only exists when
    using a bitmap console. Don't allow RIP to be enabled, and don't
    perform the operations that require the lock when the CONIO_OPT_SET_PIXEL ciolib option is not set.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Wednesday, August 02, 2023 22:57:00
    https://gitlab.synchro.net/main/sbbs/-/commit/236064ee462ca2be3b81cd77
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Properly read extended keys in non-graphics builds.

    Fixes SF issue 118

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Thursday, February 15, 2024 15:04:00
    https://gitlab.synchro.net/main/sbbs/-/commit/ec4a8c96c24994cb157ac491
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Move fiddling with rip.x_max and rip.y_max out of the vstat mutex.

    Apparently, fiddling with them in there "strongly implies" to Coverity
    that vstatlock needs to be held to access them, and it's good form
    to have the lock held for the least span possible.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, March 22, 2024 02:16:00
    https://gitlab.synchro.net/main/sbbs/-/commit/4ed27ca97ae7f21f56d038b6
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Use safer string things...

    We really need strlcpy()/strlcat() wrappers in xpdev.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, September 27, 2024 23:15:55
    https://gitlab.synchro.net/main/sbbs/-/commit/75008b3055306224ca0272cc
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix a couple use-after-free bugs in RIP

    This likely is the cause of bug 140.

    The first one, the LCF flag is copied out of the cterm struct
    after cterm_end() is called (which frees the struct). Copy moved
    to before cterm_end().

    The second one is trickier... it's executing the commands in a mouse
    button, and one of the commands is to delete all the mouse button
    commands. This ends up free()ing the string that's currently being
    parsed while it's being parsed. We now use a strdup() of the string
    which we free at the end of the function.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, September 27, 2024 23:40:23
    https://gitlab.synchro.net/main/sbbs/-/commit/9fefe60690d8c378c13ccd96
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix builds that don't support any graphics.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Monday, October 28, 2024 09:47:57
    https://gitlab.synchro.net/main/sbbs/-/commit/1a74630f9654033b92b0fe28
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    When RIP changes the vstat mode, also change the cursor

    When changing between 8 and 16 row fonts in RIP mode, the cursor
    start and end was left for the old font size... 16 -> 8 would leave
    the cursor one line below the current position, and 8 -> 16 would
    leave the cursor in the middle of the cell.

    This hacks the vstat deeper to fix up the cursor as well.

    Reported by skipperdoodle1947.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Tuesday, October 29, 2024 12:11:28
    https://gitlab.synchro.net/main/sbbs/-/commit/0a78d39dd2e3389140dff826
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix handling of broken CRLF pairs in RIP mode

    If telnet binary mode is enabled (the new default), and a CR and LF
    come in on separate recv() calls, the RIP parser would stop at the
    CR, and pass the LF back to the ANSI parser.

    Ah, dura-bbs.net, always pushing the limits.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Wednesday, October 30, 2024 09:54:01
    https://gitlab.synchro.net/main/sbbs/-/commit/9b3aa58cf998d1c1015560b3
    Modified Files:
    src/syncterm/ripper.c
    Log Message:
    Fix up previous commit

    RIPtel reset to the font configured by the user, not the current
    font. Do the same here.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net