• src/sbbs3/chat.cpp

    From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Thursday, February 02, 2023 13:48:00
    https://gitlab.synchro.net/main/sbbs/-/commit/b56bf8edcf92494e56d410aa
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Sysop can chat with nodes that aren't logged-in (at logon prompt, new users)

    Be sure to let them select a node even when no nodes are technically "in use". As requested by Nelgin in IRC (what, no gitlab issue?)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Monday, April 17, 2023 11:38:00
    https://gitlab.synchro.net/main/sbbs/-/commit/44f626bbcd42e03864c73def
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Add source node number to sysop notification that they're being paged to chat

    Fix issue #551

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Friday, April 28, 2023 23:58:00
    https://gitlab.synchro.net/main/sbbs/-/commit/62e2280e6e59c520eae9abb4
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Fix buffer overflow in guru chat parsing engine

    The trigger was this line in the recent change to guru.dat:
    Unrealized potential. :-(

    That open paren was parsed as the beginning of a new guru expression. A very long guru expression that overflowed the stack variable 'str' here.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS@VERT to Git commit to main/sbbs/master on Sunday, April 30, 2023 15:20:00
    https://gitlab.synchro.net/main/sbbs/-/commit/5fd4f1ca4a66fa612d243c0b
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    A close-parenthesis in a guru.dat response string would throw-off the parser

    After a negative-match of a Guru expression, we were searching for the next
    '(' anywhere in the subsequent chars of the file rather than just the next
    line that started with an open-parenthesis character.

    This bug was the secondary cause of the buffer-overflow crash addresseed in commit 62e2280e which was triggered by my recent updates to the guru.dat.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows@VERT to Git commit to main/sbbs/master on Saturday, March 23, 2024 17:19:00
    https://gitlab.synchro.net/main/sbbs/-/commit/39934b3b272b55412a3e211c
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Fix CID 33725: Use after close

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows@VERT to Git commit to main/sbbs/master on Monday, April 22, 2024 23:13:00
    https://gitlab.synchro.net/main/sbbs/-/commit/750bea33377fd220b013db96
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Don't allow sysops to page or send messages to nodes without a useron

    Fix a long standing bug where by sysops could page for chat or send node messages or telegrams to any node, even if there wasn't a user even connected.

    Regular users were not affected by this bug.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows@VERT to Git commit to main/sbbs/master on Saturday, April 27, 2024 17:03:00
    https://gitlab.synchro.net/main/sbbs/-/commit/d672f39b4592c71f1d0a2fbd
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Use bool type to eliminate MSVC warning

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net