1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/xpdev/gen_defs.h

    From Rob Swindell@VERT to Git commit to main/sbbs/master on Tuesday, January 24, 2023 12:44:00
    https://gitlab.synchro.net/main/sbbs/-/commit/c0e857c930feb9833d40617f
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Make SAFECOPY() even safer by not passing NULL destination to strncpy()

    This should resolve (new) CID 434884 and 434885.

    Also, remove the SAFECOPY_USES_SPRINTF check/block - nobody enables this.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS@VERT to Git commit to main/sbbs/master on Thursday, January 26, 2023 23:30:00
    https://gitlab.synchro.net/main/sbbs/-/commit/1e3a6b84e7bc1485b2a96828
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Revert "Make SAFECOPY() even safer by not passing NULL destination to strncpy()"

    This reverts commit c0e857c930feb9833d40617f00ff5d11be9f7772.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS@VERT to Git commit to main/sbbs/master on Thursday, January 26, 2023 23:45:00
    https://gitlab.synchro.net/main/sbbs/-/commit/ea99ca801e63268479f91e94
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Add XSAFECOPY (extra safe copy) that won't pass NULL to strncpy()

    The previous (reverted) change to SAFECOPY would double-resolve the (src) argument and caused weird side effects.

    Again, removes SAFECOPY_USES_SNPRINTF since it was unused.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, March 22, 2024 11:38:00
    https://gitlab.synchro.net/main/sbbs/-/commit/ffd5385d1510e7da8a547970
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Use strlcpy() for X?SAFECOPY() macros.

    Also, for DEBUG builds, add a static assertion that
    sizeof(dst) != sizeof(void*) to catch the most common breakage.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, March 22, 2024 11:42:00
    https://gitlab.synchro.net/main/sbbs/-/commit/d13fa3bd3eb4953a587c6d5d
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Use static_assert() macro instead of _Static_assert keyword

    More compatible with C++ that way.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian L@VERT to Git commit to main/sbbs/master on Friday, March 22, 2024 11:48:00
    https://gitlab.synchro.net/main/sbbs/-/commit/a8c0ac5da5374f83333b570e
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Fix stale comment about XSAFECOPY (now uses strlcpy, not strncpy)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, March 22, 2024 11:48:00
    https://gitlab.synchro.net/main/sbbs/-/commit/2b3a174068b33c4c947b2b21
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    static_assert() only available with C11 and higher.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, March 22, 2024 11:50:00
    https://gitlab.synchro.net/main/sbbs/-/commit/406ea9488765141c69185e81
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Borland expects ()

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, March 22, 2024 11:53:00
    https://gitlab.synchro.net/main/sbbs/-/commit/a987cf4b49ff92f4925f7106
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Stop interlacing preprocessor stuff.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, March 22, 2024 23:11:00
    https://gitlab.synchro.net/main/sbbs/-/commit/c64357b949c68ff54489f1e1
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    include genwrap.h at the end of gen_defs.h for strlcpy()/strlcat().

    This whole library is starting to get crufty and could use a room
    at a hackathon.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows@VERT to Git commit to main/sbbs/master on Sunday, March 24, 2024 17:58:00
    https://gitlab.synchro.net/main/sbbs/-/commit/be523ad92bf537adb4c195f3
    Modified Files:
    src/xpdev/gen_defs.h
    Log Message:
    Remove obsolete note comment about genwrap.h

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net