https://gitlab.synchro.net/main/sbbs/-/commit/41ace72c24800de0fa0b3b23
Modified Files:
src/sbbs3/js_filebase.c
Log Message:
Fix filebase corruption caused by FileBase.renew()

echicken reported this problem: pretty severe filebase corruption as a result of calling FileBase.renew(). The problem seemed pretty obvious (only loading the file's index record), but I do think the underlying SMBLIB functions
should be more resilient to misuse and not corrupt the base. So, that's still
a TODO.

No existing scripts were using FileBase.renew(), so this problem has gone unnoticed since SBBS v3.19.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/22d7343f21cbd9cee29a4118
Modified Files:
src/sbbs3/js_filebase.c
Log Message:
Rename the METADATA and metadata properties to AUXDATA and auxdata

To eliminate confusion with the file-meta-object that this API deals with
more than anything else.

echicken's suggestion

Nothing used this property before now, so this should be fine.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ad309d463528da40cfd32354
Modified Files:
src/sbbs3/js_filebase.c
Log Message:
Fix misuse of JSVAL_TO_DOUBLE() for "cost" and "size" file-meta-obj properties

As pointed out by echicken: when setting the "cost" property to any value, the actual
file's cost would be set to 9223372036854776000 regardless of what number was in the
provided file metadata object. Most jsval numbers aren't doubles (they're ints) so
need to use JS_ValueToNumber() to do the proper conversion, regardless of underlying
type.

Noticed the same problem with the "size" property.

Thanks for the tests and report echicken!

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0dbd3f064a2dee66cca6c409
Modified Files:
src/sbbs3/js_filebase.c
Log Message:
Fix some apparent memory leaks when using file's auxdata

Nobody's really using this auxdata yet, besides echicken, so no impact for others.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/831ddd710d935eee37639446
Modified Files:
src/sbbs3/js_filebase.c
Log Message:
When FileBase.update() is called with readd_always=true, update date-added

The use from addfiles.js (the -readd option) implies this is what's expected. And echicken was suprised the 'added' date/time-stamp wasn't udpated.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/946e42d6fc4e56de23c8c664
Modified Files:
src/sbbs3/js_filebase.c
Log Message:
FileBase.add() now supports override to *never* extract/use DIZ if desired

Working on fileman.js, when moving files to another base, the output of unzip (trying to extra a FILE_ID.DIZ) was corrupting the display. We don't really want a DIZ file to get imported when moving files between bases anyway.

So the second parameter to FileBase.add() can be either:
- undefined: will try to extract/use DIZ only if there's no ext desc already
- true: will try to extract/use a DIZ even if there's an ext desc already
- false: will never try to extract/use a DIZ

If the directory is not configured for DIZ support, then the DIZ extraction/use will never occur under any condition.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/35cde60c2a947b8a5e2ce2c4
Modified Files:
src/sbbs3/js_filebase.c
Log Message:
Better JSDOC description of use_diz param to FileBase.add()

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/32e880895b1acec254d426ad
Modified Files:
src/sbbs3/js_filebase.c
Log Message:
Fix 64-char filename length limit for FileBase.get[_path/size/time] methods

This was only a problem when these methods were passed a file-meta-object instead of the file name. In hindsight, that's kind of a dumb API "feature" since we're just parsing the name property out of the object.

The file_t.file_idx.name is limited to 64 chars, so don't use that struct element to store the parsed "name" property of the passed file-meta-object.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f532bee963c7e7fb6df4fc77
Modified Files:
src/sbbs3/js_filebase.c
Log Message:
Fix bug with FileBase.get_time() for filenames > 64 chars in length

We need to read the file header (not just index) entry to get the actual
full filename.

Also, removed some extraneous calls to getfilepath() that served no
purposed.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/726a08527c590b38136b7ef7
Modified Files:
src/sbbs3/js_filebase.c
Log Message:
Fix new small memory leak (no need to use strdup here)

Fix CID 497098

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2fc23c32c4b0b19685f2cb0e
Modified Files:
src/sbbs3/js_filebase.c
Log Message:
FileBase.update() method throws more exceptions upon error

This will help to determine cause of any file update (e.g. rename)
failures, as reported by Nelgin.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/397d6ebe5b0185bdff5c0c59
Modified Files:
src/sbbs3/js_filebase.c
Log Message:
Don't allow FileBase.update() to create a duplicate file

FileBase.update() will now throw an exception if attempting to rename a file
to a filename that already exists in the filebase index.

Prior to this change, one could (via JS methods) rename a file in the base to create a duplicate filename which would corrupt the base (one index entry and two header records for the same filename).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2391c3c9a3912622b8016333
Modified Files:
src/sbbs3/js_filebase.c
Log Message:
Update JSDOC description of update() method

Clarify that this is the method to use to rename a file.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net