https://gitlab.synchro.net/main/sbbs/-/commit/646c7e10fe6c138fa7e095f8
Modified Files:
src/conio/x_events.c
Log Message:
Remove unised variable.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0544e9c52e731ffa4d157918
Modified Files:
src/conio/x_events.c
Log Message:
Handle all possible failure paths before calling bitmap_drv_init()

Should fix auto-curses mode crash.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c6d284b31bd859b9b70587d7
Modified Files:
src/conio/x_events.c
Log Message:
Swap the order of defaults so vstat.scaling only gets written once

This is just to make it less noise to watch vstat.scaling from gdb.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/96252a524edfdd8b7952062f
Modified Files:
src/conio/x_events.c
Log Message:
Call resize_window() after initing a mode, call XResizeWindow() if x_cvstat doesn't match cvstat.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/acc0bffc446abdbb27455127
Modified Files:
src/conio/x_events.c
Log Message:
Fixup vstat after bitmap_drv_init_mode()

Now that vstat is what was last drawn on the screen we need to
save/restore the width/height around calls to bitmap_drv_init_mode().

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/cf317d5db18cfadec0a2a6fa
Modified Files:
src/conio/x_events.c
Log Message:
Fix (unlikely) deadlock when load_vmode() fails.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/87f05b6d89fd176435a80fd0
Modified Files:
src/conio/x_events.c
Log Message:
Use vstat.scaling not x_cvstat.scaling to scale to screen.

Also, do not try to display frames where the scaled height or width
is less than the frame bitmap height or width.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/00aeb6ecf848d69ccecad87e
Modified Files:
src/conio/x_events.c
Log Message:
More X optimizations

Now that bitmap_drv_request_some_pixels() just calls bitmap_drv_request_pixels(), there's no point in calling expose_rect()
when ev->xexpose.count isn't zero.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9b165510cb465af2403e014d
Modified Files:
src/conio/x_events.c
Log Message:
On a ConfigureNotify event, only call handle_resize_event() if size changed.

This mirrors commit 0748cc1e about a year ago that optimized window
dragging, and performs basically the same check (removed a week ago
with commit b4ce023c)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d8de9251cafb98c47857bccd
Modified Files:
src/conio/x_events.c
Log Message:
Use video mode aspect ratio when defined rather than pixel size.

There's no good argument for this aside from "it feels more right".

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/860680f59f8790f0893f3fdc
Modified Files:
src/conio/x_events.c
Log Message:
Fix inverted logic in last commit

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/4bfdec46f56ca4ae0711bf0d
Modified Files:
src/conio/x_events.c
Log Message:
Fiddle with WM_NORMAL_HINTS a bit.

USize was wrong, PSize wasn't set, and PBaseSize was set, but flag wasn't.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/fcf101424c46e57a3ff36b87
Modified Files:
src/conio/x_events.c
Log Message:
Ye old typo in last commit

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ae643313d5df9f3dfe4fe6be
Modified Files:
src/conio/x_events.c
Log Message:
Disable X Synchronize and some minr optimizations in set_icon()

The XSynchronize disablement is the most important here... didn't
realize it defaulted to enabled, which has been slowing down a *lot*
of stuff for a long time... not that there's much left that benefits
from disabling Synchronized XLib except this new terrible icon thing.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/76641ca7d66bdd0eaa86bc9e
Modified Files:
src/conio/x_events.c
Log Message:
Set _NET_WM_PID

Seems like a good idea, should allow WMs to kill hung processes and
stuff like that.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/20d77d5a501bcb51eb98d31c
Modified Files:
src/conio/x_events.c
Log Message:
Implement the _NET_WM_PING protcol

Implied by _NET_WM_PID being set, so may as well do it.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/b0feed94406571e18586f8fb
Modified Files:
src/conio/x_events.c
Log Message:
Fix use of uninitialized value

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/11050ff199521fe2b09686ff
Modified Files:
src/conio/x_events.c
Log Message:
Fix up source/last for external scaling

This was ending up using an uninitialized value

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d3a6cc915ab802da7f0fbdf3
Modified Files:
src/conio/x_events.c
Log Message:
Fix typo in line 666

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f3817229ab1a1eafac543d49
Modified Files:
src/conio/x_events.c
Log Message:
Increment offset in the loop when reading _NET_WORKAREA

Previously, if there was more than one work area, this would be
an infinite loop, re-reading the first workarea repeatedly.

Reported by Ragnarok (thanks!)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/08f465dbb94c3a6580f702de
Modified Files:
src/conio/x_events.c
Log Message:
More fullscreen work, get resize working

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3b7791526d3cd7263c2d654d
Modified Files:
src/conio/x_events.c
Log Message:
For Sommelier (ie: ChromeOS), use CLIPBOARD not PRIMARY

ChromeOS (as of Jun 2023) effectivly makes PRIMARY useless. Just
do the wrong thing and use CLIPBOARD instead. This makes it much
more likely that SyncTERM selections will clobber CLIPBOARD
unintentionally, but we have no choice... DigitalMan doesn't use
X11 mode solely because ChromeOS sucks at X11.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6ec4d431f63669f30b07f4be
Modified Files:
src/conio/x_events.c
Log Message:
Fix some highly unlikely memory leaks

- Ensure last is cleared even if we manage external scaling without Xrender
- Free the bitmap rectangle in the same situation
- Make a copy of x_internal_scaling so it's used consistently
(not mutex protected, and accessed from multiple threads)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7f01faf0ca9f9fd0939e0184
Modified Files:
src/conio/x_events.c
Log Message:
Fix wildly incorrect usage of set_win_property().

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d0280d9d8272860d4523eb09
Modified Files:
src/conio/x_events.c
Log Message:
Fix fullscreen external scaled X11 mode

Was not using struts, and was scaling to window size, not aspect
ratio size.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/2d3f4e18c1168e575175bf18
Modified Files:
src/conio/x_events.c
Log Message:
Fix black bar generation

Was wrong and therefore causing flickering.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9ef4042cfdc943eb7a75cd29
Modified Files:
src/conio/x_events.c
Log Message:
Some minor fixups...

On expose, always redraw the entire screen. The calculations were
wrong and with fractional scaling, some of them will always be wrong.

Don't clear the screen when xim is resized.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e1a6e1ac8e83d2e41a394bc6
Modified Files:
src/conio/x_events.c
Log Message:
Attempt to set resource name/class correctly for XIM

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/325bafccd9c2a51c17cdd1ed
Modified Files:
src/conio/x_events.c
Log Message:
Missed a 'C' in ICCCM

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/04efb20ca85d82b36d5b554e
Modified Files:
src/conio/x_events.c
Log Message:
Don't require caller to call textmode() before showing window

Fixes recent regression with scfg

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/503cff8671462889d573ee26
Modified Files:
src/conio/x_events.c
Log Message:
Fix GCC v10.2 warnings about ignored return values of 'write'

The return value of x11_event() isn't actually checked anywhere currently, but still Deuce might want to adjust the new return value here (__LINE__ or -1?).

Some indicental trailing whitespace was auto-cleaned up part of this commit. Unexpected as I thought this code had been uncrustified already.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/58ed4743698f8f3539c27931
Modified Files:
src/conio/x_events.c
Log Message:
Make x11_event() a bool

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/00ab0718520a123a36113a43
Modified Files:
src/conio/x_events.c
Log Message:
Actually, this is a blocking write, just compare with -1

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/777fb6d8bec3c7dd85e6d919
Modified Files:
src/conio/x_events.c
Log Message:
Actually, don't bother returning a value that's never used.

Still be sure to check the return value of write() though.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e61a1aa6c7b27242fc1d0340
Modified Files:
src/conio/x_events.c
Log Message:
Use XDG_ENVIRONMENT_TYPE to switch to CLIPBOARD

It appears that XDG_ENVIRONMENT_TYPE will always equal "wayland"
when XWayland is in use, so when we see that, switch to CLIPBOARD
instead of PRIMARY. This should fix WSL and ChromeOS, and be
irritating on GNOME, so it's a win all around.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/4f504677859909d59443a17b
Modified Files:
src/conio/x_events.c
Log Message:
Revert "Use XDG_ENVIRONMENT_TYPE to switch to CLIPBOARD"

This reverts commit e61a1aa6c7b27242fc1d03401b4240c6f58ac311.

It turns out neither platform this targeted actually set that
variable correctly.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d60cc9637f418ab7aa897945
Modified Files:
src/conio/x_events.c
Log Message:
Remove stale code from net_wm_state_is_cb()

It's unlikely this is what Digitalman reported from ASan and UBSan

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0a6fdb956890d029bfdb230f
Modified Files:
src/conio/x_events.c
Log Message:
Fix crash in net_wm_state_is_cb when running GCC ASan-enabled build

Check size of X11 property before dereferencing as an Atom.
This fixes:
==10203==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000065970 at pc 0x5c5834fb8812 bp 0x7819c717c220 sp 0x7819c717c218
READ of size 8 at 0x602000065970 thread T2 (X11 Events)
#0 0x5c5834fb8811 in net_wm_state_is_cb ../conio/x_events.c:1541

But I'm not clear when nitems_return (nir) might represent > 8-bit items or how to detect that, so perhaps there's a *better* fix?

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e32a036b1b615aa2c07cbefc
Modified Files:
src/conio/x_events.c
Log Message:
Revert "Fix crash in net_wm_state_is_cb when running GCC ASan-enabled build"

This reverts commit 0a6fdb956890d029bfdb230f3fec17110690a471.

This simply caused the callback to never be called.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/60668a729f1fdb570284a70c
Modified Files:
src/conio/x_events.c
Log Message:
Ensure we get at least one item before passing to the callback

Should fix ASan "crash".

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f2d5534ae72cd7994e25ec77
Modified Files:
src/conio/x_events.c
Log Message:
Fix CTRL + CAPS issue in X11

Previously, both the shift key, and the "implied shift" from CAPS
were treated as a higher priority than the CTRL modifier. With
this change, only the explicit shift key has priority, and the
implicit one is only checked after CTRL is checked.

Fixes SourceForge bug 117

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/bc3d9e44b16a9a6d06cbb909
Modified Files:
src/conio/x_events.c
Log Message:
Move call to bitmap_drv_free_rect() out of vstatlock

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/bb9b789ca8fc185fcdfda32d
Modified Files:
src/conio/x_events.c
Log Message:
Bow to GCC harder.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/57283c51fac9860dd350e639
Modified Files:
src/conio/x_events.c
Log Message:
Fix pasting in X11 mode... pastebuf should be UTF-8, not ISO-Latin1.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/b9c51d8b9f5aab7f368c5c76
Modified Files:
src/conio/x_events.c
Log Message:
Fix warning.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/36d37a5184d5263f8d1de3f4
Modified Files:
src/conio/x_events.c
Log Message:
Move saved_scaling inside vstatlock.

This shouldn't be necessary, but Coverity thinks it's a good idea,
and it's simple enough to do without hurting anything.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/904d202aa2b0c906cf5ef25b
Modified Files:
src/conio/x_events.c
Log Message:
Call map_window() to update size hints when resizing the window.

This way, WMs that enforce aspect ratio etc, won't get potentially
block the update.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/375bdb7806d6ef2996a6a7b7
Modified Files:
src/conio/x_events.c
Log Message:
Use max when we have it, only restore size/scaling in fullscreen mode

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f616a09a6bf5bdd88e247850
Modified Files:
src/conio/x_events.c
Log Message:
First attempt to fix "black bars" startup issue.

The first time we receive a MapNotify or ConfigureNotify that sets
the width and height, resize the window instead of accepting the
current window size.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/129dd7db9d00fe4be9f9b93a
Modified Files:
src/conio/x_events.c
Log Message:
Only count it as the "first resize" if it's not from SendEvent()

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/bd1c91e6bf0a98cb6f3ef43c
Modified Files:
src/conio/x_events.c
Log Message:
Always base scaling on size, and alwayse resize xim.

Fixes issue with possible corrupt display when "weird" scaling
changes occured.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/37c79a65585b06197c219697
Modified Files:
src/conio/x_events.c
Log Message:
Count flushes to disable resize hack.

Instead of strictly using "first resize", also count flushes and
assume the hack isn't needed after five. Experimentation on my
ChromeBook shows 3 to be sufficient, so I'm sing five for now.

Odds are that this will still mess with tiling WMs, but I don't use
one, so I don't mind yet. I expect this will be better, but likely
still not great.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a130c61289d7bc2217d61665
Modified Files:
src/conio/x_events.c
Log Message:
Lower flush count to 3.

This is my happy place on the desktop system running xfce4... any
higher, and it interferes with how I manage my windows.

Hopefully, this value convers the initialization portion perfectly
on all systems (hah!).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/fd0b6150ce3fb8c64b9ec0e3
Modified Files:
src/conio/x_events.c
Log Message:
Fix some weirdness around window sizing.

This should fix the recent issue when a larger or smaller version
is painted inside the window after resize, as well as fix ALT-
when the current size is not an integer multiple.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f5160b014413cbfee9c8ec7c
Modified Files:
src/conio/x_events.c
Log Message:
Fix build when XRandR is available, but Xinerama isn't.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f2257585720b4972280f48da
Modified Files:
src/conio/x_events.c
Log Message:
Actually don't call XSetICFocus() at start. :(

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/235ce71a6a01a20d6b3801a5
Modified Files:
src/conio/x_events.c
Log Message:
Never call XMapWindow() in response to a _NET_FRAME_EXTENTS change

This breaks at least herbstluftwm's focus-follows-mouse, and rustles
Cyan's jimmies.

It's also a terrible idea.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/56c269ffc22dde02df5df429
Modified Files:
src/conio/x_events.c
Log Message:
If we're not mapping, only XSetWMNormalHints() if it's different.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d58c1bba6f02c14d23fe06c9
Modified Files:
src/conio/x_events.c
Log Message:
Refine last commit...

Add a comment explaining why we do what we do, and verify the aspect
is unchanged as well since we could change only the aspect and need
to set new hints in some cases.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ea0e1c4999f98b8804ece464
Modified Files:
src/conio/x_events.c
Log Message:
Fix warnings in last commit.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/63434549e82588a0cac2404a
Modified Files:
src/conio/x_events.c
Log Message:
Fix some more warnings when not using optional features.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net