1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/sauce.c

    From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, March 22, 2024 11:38:00
    https://gitlab.synchro.net/main/sbbs/-/commit/c35dec2fbced851ce25c1627
    Modified Files:
    src/sbbs3/sauce.c
    Log Message:
    Remove gratuitous use of comma operator.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows@VERT to Git commit to main/sbbs/master on Saturday, March 23, 2024 16:12:00
    https://gitlab.synchro.net/main/sbbs/-/commit/c8634c7adc3633923d5db58f
    Modified Files:
    src/sbbs3/sauce.c
    Log Message:
    SAFECOPY (now using strlcpy) requires the source is terminated

    ... so use strncpy() and TERMINATE() here (instead of SAFECOPY) to resolve newly reported Coverity issues.

    There may be other places where we're using SAFECOPY() with an unterminated source string that would've been fine before we switched SAFECOPY from using strncpy to strlcpy. So we should reconsider that change.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net